Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with custom button groups #1334

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Fixed issue with custom button groups #1334

merged 1 commit into from
Dec 8, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Dec 8, 2017

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

@chalettu
Copy link
Contributor Author

chalettu commented Dec 8, 2017

This fix is related to #1254.

@chalettu
Copy link
Contributor Author

chalettu commented Dec 8, 2017

Before. before_button

@chalettu
Copy link
Contributor Author

chalettu commented Dec 8, 2017

After -
fixed

@AllenBW AllenBW added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 8, 2017
@AllenBW AllenBW self-assigned this Dec 8, 2017
AllenBW
AllenBW approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE NICE NICE 🌮 🎉

@miq-bot
Copy link
Member

miq-bot commented Dec 8, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/e688b367dfff026a87e14ed10eaefde8421b141e with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@AllenBW AllenBW merged commit 053683a into ManageIQ:master Dec 8, 2017
@AllenBW AllenBW deleted the custom-button-groups branch December 8, 2017 16:38
simaishi pushed a commit that referenced this pull request Dec 11, 2017
@AllenBW @simaishi
Merge pull request #1334 from chalettu/custom-button-groups
749f5ed 
Fixed issue with custom button groups
(cherry picked from commit 053683a)

https://bugzilla.redhat.com/show_bug.cgi?id=1524718
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 749f5edcabb48bcae4ec7aa508c3080cf73f7ecc
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Fri Dec 8 11:38:22 2017 -0500

    Merge pull request #1334 from chalettu/custom-button-groups
    
    Fixed issue with custom button groups
    (cherry picked from commit 053683a715e900dddc49172eea07a208ad009393)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1524718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

@himdel himdel Awaiting requested review from himdel

Assignees

@AllenBW AllenBW

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @simaishi @AllenBW