BZ#1523653-Replace patternfly-sass with patternfly's sass #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenamarie125
approved these changes
Dec 8, 2017
|
Premature labeling :) |
|
@miq-bot add_label ux/review |
|
@miq-bot remove_label ux/approved |
serenamarie125
suggested changes
Dec 8, 2017
There was a problem hiding this comment.
I got so excited, I approved too early! Tag me when ready for approval @AllenBW
|
almost outta wip! almost! 🤔 will do! 🤗 🙇♀️ 🦁 |
|
This pull request is not mergeable. Please rebase and repush. |
AllenBW
force-pushed
the
enhancement/master/#1329-depreciate-patternfly-sass-use-patternflys-sass
branch
from
3fc2978 to
d5b8ecf
Compare
AllenBW
changed the title
No longer need patternfly-additions
AllenBW
force-pushed
the
enhancement/master/#1329-depreciate-patternfly-sass-use-patternflys-sass
branch
from
d5b8ecf to
34771c4
Compare
|
Checked commits AllenBW/manageiq-ui-service@5429aaa~...34771c4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
serenamarie125
approved these changes
Dec 11, 2017
|
@miq-bot add_label ux/approved |
himdel
approved these changes
Dec 12, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 12, 2017
…iate-patternfly-sass-use-patternflys-sass BZ#1523653-Replace patternfly-sass with patternfly's sass (cherry picked from commit 0db6896) https://bugzilla.redhat.com/show_bug.cgi?id=1525082
|
Gaprindashvili backport details: |
AllenBW
deleted the
enhancement/master/#1329-depreciate-patternfly-sass-use-patternflys-sass
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1523653
closes #1329
Update Ok so this is g2g save that outstanding pr in the patternfly repo, once a fix for that shows up we can merge this in
Outstanding bugs with pffffffffsass (these should all be resolved before merging this in, hence wip)
fix(page-layout):revises condensed masthead mobile view patternfly/patternfly#879 ❓ ya don't see the cool little background on the login block‼️ Workspace Enhancement: Migration Docs need to support full page layouts patternfly/patternfly#880Change hbs attributes to lower-case, add icon hbs file patternfly/patternfly#883Changes this work brings
Using patternfly notification badges