BZ#1517101-Adds empty state to service details relationship section #1292

AllenBW · 2017-11-30T15:15:26Z

https://bugzilla.redhat.com/show_bug.cgi?id=1517101

When no relationship information was available, we were showing the title with an empty body (made it look like a bug). This fix adds the pf-empty state to the body that clearly indicates no information is available

After (two examples, cuz its nice to see different types)

Before (two examples, cuz its nice to see different types)

AllenBW · 2017-12-04T12:28:48Z

@serenamarie125 any chance we can get your eyes on this today? 🙇‍♀️ ❤️

chalettu

Looks good to me

serenamarie125 · 2017-12-04T17:45:50Z

Hey @AllenBW - in this case, is it that there is no info available or that no relationships exist?

AllenBW · 2017-12-04T19:28:25Z

@serenamarie125 That there is no info available 👍

serenamarie125

Please change the text of the empty state pattern to be "No data available", as that matches what we use in other areas.

I think it's an issue that we are showing "No data available" rather than reporting that no relationships exist. But from what you are saying, you don't know the difference between no relationships and you got nothing, so we don't have a choice. @Loicavenel fyi

himdel · 2017-12-05T17:39:57Z

@serenamarie125 Was that the last issue? Can we ux/approved now that it's fixed? :) Thanks

himdel · 2017-12-05T17:42:40Z

client/app/services/service-details/service-details.component.js

@@ -32,6 +32,7 @@ function ComponentController ($stateParams, $state, $window, CollectionsApi, Eve
      availableTags: [],
      credential: {},
      listActions: [],
+      emptyState: {icon: 'pficon pficon-help', title: 'No data available'},


Missing i18n? (since it is in the other emptyState)

(and for those getInfo / provInfo messages?)

GOOOOOOOD catch ❤️

AllenBW · 2017-12-05T17:44:25Z

@serenamarie125 Wording has been update, following screenshots reflect current wording

himdel · 2017-12-05T17:45:13Z

client/app/services/service-details/service-details.html

@@ -371,7 +371,9 @@ <h2 translate>Resources</h2>
        <div class="panel-body">
            <section>
                <h2 translate>Relationships</h2>
-                <div class="container-fluid">
+                <pf-empty-state ng-if="!vm.service.parent_service || !vm.service.service_template" config="vm.emptyState"></pf-empty-state>


&& not ||

(because negating a || b gives !a && !b ;)

(Unless the goal was really to display "No data available" even if only one of those is missing, but that looks weird, with the list right under it.)

good call on the &&!!

updated the pr

serenamarie125

LGTM! Thanks @AllenBW

serenamarie125 · 2017-12-05T18:04:30Z

@miq-bot add_labels ux/review

serenamarie125 · 2017-12-05T18:04:36Z

@miq-bot add_labels ux/approved

himdel · 2017-12-05T18:45:54Z

Almost LGTM 👍

Except, oops, one more broken thing..

When you have a service with just vm.service.service_template, that one line is not actually visible in the UI because it's hidden under the window edge..

Looks like somebody forgot to adjust ss-details-wrapper styling when adding a toolbar, or something like that... changing .ss-details-wrapper height from calc(100vh - 98px) to calc(100vh - 149px) makes it look like this..

@AllenBW is that something you want to fix in this PR or is this unrelated?

miq-bot · 2017-12-05T19:08:31Z

Checked commits AllenBW/manageiq-ui-service@a39f37e~...06063c0 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

AllenBW · 2017-12-05T19:08:48Z

DANG @himdel fantastic catch <3

Updated, looks like we were missing a ss-details-wrapper-with-toolbar class 🤦‍♂️

himdel · 2017-12-05T19:09:20Z

Perfect @AllenBW thanks! :)

Retested, merging when green..

…ils-relationship-empty-state BZ#1517101-Adds empty state to service details relationship section (cherry picked from commit 915ac21) https://bugzilla.redhat.com/show_bug.cgi?id=1524716

simaishi · 2017-12-11T21:50:01Z

Gaprindashvili backport details:

$ git log -1
commit c906bdb0d1d08ff3664fe4dc872ea8456484a9fb
Author: Martin Hradil <himdel@seznam.cz>
Date:   Tue Dec 5 19:14:53 2017 +0000

    Merge pull request #1292 from AllenBW/BZ/MASTER/#1517101-service-details-relationship-empty-state
    
    BZ#1517101-Adds empty state to service details relationship section
    (cherry picked from commit 915ac21ed6b0d1814d8d4c551de3293dac6a945e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1524716

AllenBW requested a review from chriskacerguis as a code owner November 30, 2017 15:15

AllenBW added gaprindashvili/yes bug labels Nov 30, 2017

AllenBW added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 30, 2017

AllenBW assigned chriskacerguis Nov 30, 2017

chriskacerguis added the ux/review label Nov 30, 2017

chriskacerguis approved these changes Nov 30, 2017

View reviewed changes

miq-bot unassigned chriskacerguis Dec 2, 2017

AllenBW requested review from ohadlevy and himdel December 4, 2017 12:29

AllenBW assigned himdel Dec 4, 2017

AllenBW requested review from chalettu and removed request for ohadlevy December 4, 2017 15:16

chalettu approved these changes Dec 4, 2017

View reviewed changes

serenamarie125 suggested changes Dec 5, 2017

View reviewed changes

himdel reviewed Dec 5, 2017

View reviewed changes

Adds empty state to service details relationship section

a39f37e

AllenBW force-pushed the BZ/MASTER/#1517101-service-details-relationship-empty-state branch from 6ab9624 to a7ae903 Compare December 5, 2017 17:43

himdel reviewed Dec 5, 2017

View reviewed changes

serenamarie125 approved these changes Dec 5, 2017

View reviewed changes

miq-bot added the ux/approved label Dec 5, 2017

AllenBW force-pushed the BZ/MASTER/#1517101-service-details-relationship-empty-state branch from a7ae903 to ed8ce3c Compare December 5, 2017 18:21

himdel removed the ux/review label Dec 5, 2017

Reconfigure empty state wording to align with patternfly

fea7953

AllenBW force-pushed the BZ/MASTER/#1517101-service-details-relationship-empty-state branch from ed8ce3c to fea7953 Compare December 5, 2017 18:32

Ensure correct viewport size (with toolbar)

06063c0

himdel approved these changes Dec 5, 2017

View reviewed changes

himdel merged commit 915ac21 into ManageIQ:master Dec 5, 2017

AllenBW deleted the BZ/MASTER/#1517101-service-details-relationship-empty-state branch December 6, 2017 11:33

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Dec 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BZ#1517101-Adds empty state to service details relationship section #1292

BZ#1517101-Adds empty state to service details relationship section #1292

AllenBW commented Nov 30, 2017 •

edited

Loading

AllenBW commented Dec 4, 2017

chalettu left a comment

serenamarie125 commented Dec 4, 2017

AllenBW commented Dec 4, 2017

serenamarie125 left a comment

himdel commented Dec 5, 2017

himdel Dec 5, 2017

AllenBW Dec 5, 2017

AllenBW commented Dec 5, 2017

himdel Dec 5, 2017

himdel Dec 5, 2017 •

edited

Loading

AllenBW Dec 5, 2017

serenamarie125 left a comment

serenamarie125 commented Dec 5, 2017

serenamarie125 commented Dec 5, 2017

himdel commented Dec 5, 2017

miq-bot commented Dec 5, 2017

AllenBW commented Dec 5, 2017

himdel commented Dec 5, 2017

simaishi commented Dec 11, 2017

BZ#1517101-Adds empty state to service details relationship section #1292

BZ#1517101-Adds empty state to service details relationship section #1292

Conversation

AllenBW commented Nov 30, 2017 • edited Loading

After (two examples, cuz its nice to see different types)

Before (two examples, cuz its nice to see different types)

AllenBW commented Dec 4, 2017

chalettu left a comment

Choose a reason for hiding this comment

serenamarie125 commented Dec 4, 2017

AllenBW commented Dec 4, 2017

serenamarie125 left a comment

Choose a reason for hiding this comment

himdel commented Dec 5, 2017

himdel Dec 5, 2017

Choose a reason for hiding this comment

AllenBW Dec 5, 2017

Choose a reason for hiding this comment

AllenBW commented Dec 5, 2017

himdel Dec 5, 2017

Choose a reason for hiding this comment

himdel Dec 5, 2017 • edited Loading

Choose a reason for hiding this comment

AllenBW Dec 5, 2017

Choose a reason for hiding this comment

serenamarie125 left a comment

Choose a reason for hiding this comment

serenamarie125 commented Dec 5, 2017

serenamarie125 commented Dec 5, 2017

himdel commented Dec 5, 2017

miq-bot commented Dec 5, 2017

AllenBW commented Dec 5, 2017

himdel commented Dec 5, 2017

simaishi commented Dec 11, 2017

AllenBW commented Nov 30, 2017 •

edited

Loading

himdel Dec 5, 2017 •

edited

Loading