Update console behavior as per api changes #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jntullo |
AllenBW
changed the title
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Nov 28, 2017
AllenBW
force-pushed
the
bug/master/#0000-console_supported
branch
from
4b29d2e to
2bf1618
Compare
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Nov 28, 2017
AllenBW
changed the title
AllenBW
force-pushed
the
bug/master/#0000-console_supported
branch
from
2bf1618 to
b8d76c7
Compare
|
@chriskacerguis looks like miq stuff has been merged, confirmed this is the right fix, we're g2g here ☝️ look it works! |
|
Checked commit AllenBW@b8d76c7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Nov 28, 2017
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Nov 28, 2017
chriskacerguis
approved these changes
Nov 29, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 29, 2017
Update console behavior as per api changes (cherry picked from commit eb3dc98) https://bugzilla.redhat.com/show_bug.cgi?id=1510131
|
Gaprindashvili backport details: |
|
Backported to Euwe via #1283 |
|
Backported to Fine via #1282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP till ManageIQ/manageiq#16519
Ok i found the pr that was supposed to fix this last time around #1280
the companion bz is https://bugzilla.redhat.com/show_bug.cgi?id=1471158
IMPORTANT this needs to be everywhere, master, g, f, e
this pr fixes master and gaprindashvili, will need separate pr for fine and euwe
heres the bz for euwe, though it'll need a separate pr