BZ#1499692-Added Loading indicator to Dialogs

[chalettu]

BZ https://bugzilla.redhat.com/show_bug.cgi?id=1499692

[AllenBW]

@chalettu can yah provide a status update on the what work is on progress for this one?

[chalettu]

We use dialogs in 3 places in SUI and so far in this PR I got 1 of the 3 places working where we use dialogs and its tests updated. Still have custom button details and service reconfigure pages to go for fixing code and tests.

[chalettu]

@miq-bot add_label gaprindashvili/yes
@miq-bot add_label enhancement
@miq-bot add_label ux/review

[chalettu]

Screenshot of loading indicator for dialogs

[Loicavenel]

@chalettu looks good to me..
@serenamarie125 Should we add more text to be more explicit? "Loading Dialog"

[AllenBW]

LG2M Great work @chalettu !

[miq-bot]

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/8153741f2f39643e09775ea2cf721e1efa6d0796~...c81288483d8d18f803c73b3104fb9dfe126563d0 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

[serenamarie125]

I think the current text works fine! @AllenBW

[serenamarie125]

LGTM!

[serenamarie125]

@miq-bot add_label ux/approved

[serenamarie125]

@miq-bot remove_label ux/review

[AllenBW]

Looks goooooooood! <3 🙇‍♀️

[simaishi]

@chalettu @AllenBW The BZ has cfme-5.8.z flag. Is it ok to backport to Fine branch?

[AllenBW]

@simaishi are there any conflicts? This pr touches many files... if I was a betting person, would suspect there would be a few conflicts... 🤔

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 293a5fb5e20978c253d74e442035fd8f32142902
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Tue Dec 12 09:42:49 2017 -0500

    Merge pull request #1258 from chalettu/dialog-loading-fix
    
    BZ#1499692-Added Loading indicator to Dialogs
    (cherry picked from commit 8a64b773bb1a1a623c81463c1cc9adb93cd9b3d1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1525091

[simaishi]

are there any conflicts?

I ask if I should even attempt to backport first (as a fix could be something completely different for different branches) 😄

I tried it now, all but 1 file is conflicting... marking as fine/conflict

Changes to be committed:

	modified:   client/app/states/catalogs/details/details.html

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   client/app/states/catalogs/details/details.state.js
	both modified:   client/app/states/catalogs/details/details.state.spec.js
	both modified:   client/app/states/services/custom_button_details/custom_button_details.html
	both modified:   client/app/states/services/custom_button_details/custom_button_details.state.js
	both modified:   client/app/states/services/custom_button_details/custom_button_details.state.spec.js
	both modified:   client/app/states/services/reconfigure/reconfigure.html
	both modified:   client/app/states/services/reconfigure/reconfigure.state.js
	both modified:   client/app/states/services/reconfigure/reconfigure.state.spec.js

[AllenBW]

@chalettu can you look into possibly making a separate fine pr for this?

[chalettu]

Yeah, I will start on it now that this one got merged.

[simaishi]

Backported to Fine via #1341