-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to hide toasts based on RBAC #1053
Added ability to hide toasts based on RBAC #1053
Conversation
Checked commit https://github.com/chalettu/manageiq-ui-service/commit/12b4ccf5ac709df28b5efde94cb8dd598065b238 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This PR is dependent on ManageIQ/manageiq#16107 getting merged |
@chalettu @chriskacerguis are we using the Role section we are implementing? |
@Loicavenel , this is where in Classic UI you would go to enable/disable notifications |
Ok, we are good. thx |
@Loicavenel , FYI. All the PR's for allowing SUI to define its own Product features like above illustration were all merged as of yesterday. Now we can build on that functionality for any features you want to enable to be disabled granularly. Note: I just put in a PR for the notification permission this morning so that particular permission isn't merged yet but should be soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M <3 🙇♀️
@chalettu can you share the structure or we have only Notification and App Launcher for now? |
@Loicavenel , the structure pictured above is all we have defined to date. We wanted to start incrementally. Now that we have the plumbing in place, I think you and @chriskacerguis can sit down and decide on a master list we would like to add. |
Probably should start by remapping all rbac that relied on existing product features... one of the many applicable places |
@chalettu I did provide a doc about a proposed structure.. https://drive.google.com/open?id=10p69nnTT7dG0hnCBCJkcapjlxVd08J0A2QRX054B_08 |
@Loicavenel could we put that tree in this ticket? |
Sure. then people can review it. |
@miq-bot add_label enhancement
@miq-bot add_label fine/no