Added ability to disable custom buttons and show disabled text #1012
Conversation
|
GH issue #948 |
|
Screenshot |
chalettu
changed the title
|
ohhhh...shiny! |
| ng-if="vm.hasRequiredRole(button)" | ||
| ng-disabled="!button.enabled" | ||
| ng-click="vm.invokeCustomAction(button)" | ||
| > |
There was a problem hiding this comment.
its a nit, but this should be up a line
| <i ng-class="button.options.button_icon" ng-style="{color: button.options.button_color }"></i> | ||
| {{ button.name }} | ||
| </button> | ||
| <span uib-tooltip="{{(button.enabled? button.description: button.disabled_text)}}" |
There was a problem hiding this comment.
just curious, any reason why the tooltip wasn't applied directly to the button? suspicious of this new <span>
There was a problem hiding this comment.
It was added because buttons in a disabled state do not show a tooltip. It has something to do with the cursor css. I researched different solutions and the easiest/less hacky solution was to wrap the element in a simple span.
|
Checked commits https://github.com/chalettu/manageiq-ui-service/compare/563dc7f49822505821d51aa6a6b89b9bf1665f41~...890c8b4690ba697ee7adcdde43c4bf15f24369e5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
No UX change (just disabling what is there) |
@miq-bot add_label enhancement
@miq-bot add_label fine/no