Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Set onwhen to be nil if button is disabled #943

Closed
wants to merge 1 commit into from

Conversation

vecerek
Copy link

@vecerek vecerek commented Apr 6, 2017

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2017

@vecerek unrecognized command 'wip', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2017

Checked commit vecerek@4a84340 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/helpers/application_helper/button/basic.rb

@romanblanco
Copy link
Member

same changes are done in #1031, this can be closed @vecerek

@himdel himdel closed this in #1031 Apr 13, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

This pull request is not mergeable. Please rebase and repush.

@vecerek vecerek deleted the onwhen_disable_message branch April 13, 2017 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants