[WIP] Use a single view for rendering all the topology screens

[skateman]

I found out that the topology screens only differ in the entities in their legend and the angular controller name. I created a simple DSL to declare these values in the ruby controller and I moved the universal show screen into layouts/topology.html.haml.

Depends on: #955

Pivotal story: https://www.pivotaltracker.com/n/projects/1613907

[skateman]

Accessing the values declared using the DSL is realised by delegate and attr_accessor. This technique requires an extra instance variable that has a name that differs from the method which sets it.

For example, in the controller:

angular_controller 'cloudTopologyController' # gets stored in @ng_controller

Accessing it in the view:

controller.ng_controller

I'm not sure if this is The Right Way™ as it uses a pair of method-instvar with a different name, so I'd like to ask @martinpovolny and @himdel to review this.

[himdel]

Yup, I think this looks like a step in the right direction :) (assuming we do it for all of them :))

[martinpovolny]

Yes, for all or don't do it! The last thing we want is having 2 ways of doing things.

I was also thinking about not having the (ruby) controllers for topology -- having just one for all. Although that might complicate menus, toolbars and other things that

[skateman]

I want this for all the screens, of course! But we already have 2 ways of doing things 😞 the container topology is using some ✨ magic ✨ with the toolbars to build their toolbar and the others have a common partial for the same. So that needs to be addressed first...

I was thinking about creating a PR for each screen and then delete the super calls. But sure, I can add the other screens into this PR, but without the toolbar unification I can't deal with the container topology 😞 so I need to leave it out for now.

[miq-bot]

Checked commits skateman/manageiq-ui-classic@b040b6c~...9197222 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
15 files checked, 0 offenses detected
Everything looks good. 🏆

[himdel]

Missed Middleware topology ;) aand also ContainerProjectTopology which is apparently new and magic reuses a lot of ContainerTopology, but not all :) #120

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[abonas]

@miq-bot add_label topology