Remove the *TopologyApplication angular modules #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
remove-topology-application
branch
from
d072615 to
d0b9f60
Compare
|
Checked commit skateman@d0b9f60 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Agreed, makes our lives a bit easier, the only use of those modules was to make it explicit that only topologies depend on CI warnings are not new, and will be resolved in (one of) the next round of refactoring anyway (when we merge those controllers). 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@himdel told me that we actually don't need any royal navies, so I'm retiring them and using a diplomatic solution (the
ManageIQmodule) instead.Pivotal story: https://www.pivotaltracker.com/story/show/143239019