Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manager_resource only to create Repository #899

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

API needs manager_resource only for creating Repository. If send in update request Tower API will throw error as it's unwanted.
Before:
evm.log
[----] E, [2017-03-30T04:15:55.556899 #15338:fb7138] ERROR -- : MIQ(MiqQueue#deliver) Message id: [1000000009518], Error: [undefined method 'manager_resource=' for #<AnsibleTowerClient::Project:0x0000000e5695d8>]
After:
No error and Repository gets created.

https://bugzilla.redhat.com/show_bug.cgi?id=1437377

@miq-bot add_label bug, automation/ansible, fine/yes, euwe/no

@mzazrivec please review

API needs manager_resource only for creating Repository. If send in update request Tower API will throw error as it's unwanted.
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2017

Checked commit ZitaNemeckova@bcf0b50 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. ⭐

@mzazrivec mzazrivec self-assigned this Apr 4, 2017
@mzazrivec mzazrivec added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 4, 2017
@mzazrivec mzazrivec merged commit a337974 into ManageIQ:master Apr 4, 2017
simaishi pushed a commit that referenced this pull request Apr 4, 2017
Use manager_resource only to create Repository
(cherry picked from commit a337974)

https://bugzilla.redhat.com/show_bug.cgi?id=1438829
@simaishi
Copy link
Contributor

simaishi commented Apr 4, 2017

Fine backport details:

$ git log -1
commit 3f19253a8691ee3be65d10d08a24c5601359b78d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Apr 4 10:38:22 2017 +0200

    Merge pull request #899 from ZitaNemeckova/repo_api_fix
    
    Use manager_resource only to create Repository
    (cherry picked from commit a337974b7c3e7e1e281d40f08f9c501b5b9d5253)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438829

@ZitaNemeckova ZitaNemeckova deleted the repo_api_fix branch September 12, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants