Fixed quadicon link for automation providers #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, fine/yes |
lgalis
force-pushed
the
automation_providers_error_when_switching_view_type
branch
from
1d25a0c to
aa480b8
Compare
lgalis
changed the title
lgalis
changed the title
lgalis
force-pushed
the
automation_providers_error_when_switching_view_type
branch
from
c9bdea8 to
ea99233
Compare
|
This pull request is not mergeable. Please rebase and repush. |
lgalis
force-pushed
the
automation_providers_error_when_switching_view_type
branch
2 times, most recently
from
d8f0b87 to
f581f91
Compare
lgalis
force-pushed
the
automation_providers_error_when_switching_view_type
branch
2 times, most recently
from
878dcd9 to
bcde536
Compare
lgalis
changed the title
|
@dclarizio - please review |
|
@miq-bot add_label euwe/no |
lgalis
force-pushed
the
automation_providers_error_when_switching_view_type
branch
from
bcde536 to
6db1040
Compare
bdunne
reviewed
Apr 10, 2017
app/views/layouts/show_pdf.html.haml
Outdated
| @@ -4,7 +4,7 @@ | |||
| = render_quadicon(@record, :mode => :icon, :size => 72) | |||
| - if @record.kind_of?(ConfigurationProfile) | |||
| = render :partial => "#{controller}/main_configuration_profile" | |||
| - elsif @record.kind_of?(ManageIQ::Providers::AutomationManager::InventoryGroup) | |||
| - elsif @record.kind_of?(ManageIQ::Providers::ExternalAutomationManager::InventoryGroup) | |||
There was a problem hiding this comment.
Is this also supposed to be InventoryRootGroup? I don't really know what this file does, but we only refresh InventoryRootGroups right now.
bdunne
reviewed
Apr 10, 2017
| @@ -225,6 +225,11 @@ | |||
| expect(subject).to eq(helper.url_for_db(helper.controller_for_vm(helper.model_for_vm(@record)), @action)) | |||
| end | |||
|
|
|||
| it "when record is ManageIQ::Providers::AutomationManager" do | |||
| @record = ManageIQ::Providers::AutomationManager.new | |||
There was a problem hiding this comment.
Should this be testing against base classes or the leaf classes that will actually be created?
lgalis
force-pushed
the
automation_providers_error_when_switching_view_type
branch
2 times, most recently
from
cdc670a to
9bdf0a8
Compare
|
@mzazrivec - would you be able to review this? |
|
@miq-bot assign @dclarizio |
lgalis
force-pushed
the
automation_providers_error_when_switching_view_type
branch
from
9bdf0a8 to
e594ecc
Compare
|
Checked commits lgalis/manageiq-ui-classic@cdc757c~...e594ecc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 13, 2017
…witching_view_type Fixed quadicon link for automation providers (cherry picked from commit 6f5c40f) https://bugzilla.redhat.com/show_bug.cgi?id=1442174
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the switch to grid view for Ansible Tower Provider.
Also Fixes the link to the Inventory group list from the provider quadicon.
Depends on ManageIQ/manageiq#14691
https://bugzilla.redhat.com/show_bug.cgi?id=1427926