Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to select Datacenter in vm_tree with hidden vms #488

Merged
merged 2 commits into from
Mar 4, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Feb 27, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1431148

Any Vm that is directly under Datacenter folder didn't have its parent selected correctly.

VM place:
screen shot 2017-02-27 at 12 17 57 pm
Before:
screen shot 2017-02-27 at 12 16 44 pm
After:
screen shot 2017-02-27 at 12 17 21 pm

Introduced by ManageIQ/manageiq#11387 => euwe/yes

Closes #311

@miq-bot add_label euwe/yes, bug

@ZitaNemeckova
Copy link
Contributor Author

@skateman please have a look :)

@skateman
Copy link
Member

@ZitaNemeckova tests :trollface: ?

@ZitaNemeckova
Copy link
Contributor Author

@skateman It's not nice to :trollface: :P But you are right. Test added :)

@miq-bot
Copy link
Member

miq-bot commented Feb 28, 2017

Checked commits ZitaNemeckova/manageiq-ui-classic@cd4c22c~...33226ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 3 offenses detected

spec/controllers/vm_common_spec.rb

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzazrivec mzazrivec self-assigned this Mar 4, 2017
@mzazrivec mzazrivec added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 4, 2017
@mzazrivec mzazrivec merged commit 9d789aa into ManageIQ:master Mar 4, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2017

@ZitaNemeckova Is there a BZ for this? Can you please create one if it doesn't exist?

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 9f3af99c4a8b0978081d28d2fa6190ff5e3f89fd
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Sat Mar 4 20:23:23 2017 +0100

    Merge pull request #488 from ZitaNemeckova/vm_tree_fix
    
    Add condition to select Datacenter in vm_tree with hidden vms
    (cherry picked from commit 9d789aa6f6e3e0790228c7753ccfda10d2fe03bb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1431166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants