Add support for displaying network adapter details

[skovic]

Updated the physical server summary page to display details for network adapters.

[skovic]

@miq-bot add_label wip

[skovic]

@miq-bot remove_label wip

[mzazrivec]

I'm getting the following error when trying to render physical server summary:

Error caught: [ActionView::Template::Error] undefined method `child_devices' for #<GuestDevice:0x007faf13990b78>
~/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activemodel-5.0.4/lib/active_model/attribute_methods.rb:433:in `method_missing'
manageiq-ui-classic/app/helpers/physical_server_helper/textual_summary.rb:170:in `block in textual_network_adapter'

[mzazrivec]

@skovic Or is there perhaps a backend / provider PR that this change depends on?

[skovic]

@mzazrivec Yes, there are backend and provider changes that this PR depends on. The changes are in manageiq-providers-lenovo PR 59 and manageiq PR 15371.

[mzazrivec]

@skovic I'm adding pending core label to this PR. Once the backend PRs are resolved / merged,
please remove the label for the review to commence. Thanks.

[miq-bot]

Checked commits skovic/manageiq-ui-classic@d8a6242~...6a71859 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 2 offenses detected

app/views/physical_server/_textual_network_adapter_table.html.haml

• ⚠️ - Line 17 - Block has too many lines. [30/25]
• ⚠️ - Line 18 - Block has too many lines. [28/25]

[martinpovolny]

@skovic : this looks all good and mergeable 👍 However there's one thing that would help us in the future.

The textual summaries are to be converted to Angular in the future and at that point they are going to be rendered on the client side and the data will be passed in as JSON.

To make that simpler I tried to limit the number of different Textual* classes. Yes, I created the TextualCustom to support custom formatting but we will have to deal with that when we do the Angular conversion.

Could you, please, take a look if any of the app/views/shared/summary/_textual_* could be used to achieve the formatting that you need?

If you figure that none of the existing templates provides the formatting that you need, then just ping me here and we merge this as it is. But, please, take a look.

[AparnaKarve]

@skovic Can you checkout TextualMultilabel (template: 'shared/summary/textual_multilabel')?
That could work for this case.

[skovic]

@AparnaKarve I'm not sure that TextualMultilabel will be able to give me the same layout as shown in the screenshot (in regard to the ports heading and related subheadings). Also FYI, I think that the TextualMultilabel template may need to be updated. I tried using it but it keeps saying undefined variable or method 'values'. I notice that the other templates are using 'items' instead. Also, there is a typo ".pull-rigt" instead of ".pull-right" in the file. Thanks

[AparnaKarve]

@skovic I recently used TextualMultilabel in https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/generic_object_definition_helper/textual_summary.rb, and did not have any issues for my use case. The typo that you indicated, needs to be fixed, however.

From the screenshot above, perhaps the Firmware table could have used TextualMultilabel.
But as far as the Network adapters table goes, I agree that it looks a tad different where the Ports subtable is rendered.
I guess TextualCustom seems OK for your use case because of the way the Ports table is embedded in the Network adapters table.

@martinpovolny IMO, GTG.

[chargio]

@martinpovolny Hi, it seems that these changes has been approved long ago.
It is possible to merge them?

@skovic, I understand that we will have to wait until ManageIQ/manageiq#15371 is merged (the other one has already been merged).
Could you update this when that PR is merged?

[martinpovolny]

The problem is: Any new formatting added here will need to be supported when we convert this to a an angular component and when we feed in the data through some API.

I have spent significant time unifying the layouts and methods of the textual summaries so that we can do the next steps -- components and API. I don't want that effort to be wasted.

Therefor I need to be really sure that there's no other way than adding a new layout.