Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enable disabled button when items are selected #1031

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Do not enable disabled button when items are selected #1031

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b20a94
Do not enable disabled button when items are selected
yaacov Apr 13, 2017
8f7dcd3
Add comments for readability
yaacov Apr 13, 2017
36d1ae3
Add a method comment
yaacov Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions app/helpers/application_helper/button/basic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,24 @@ def localized(key, value = nil)
# self[:prompt] -- the user has to confirm the action
# self[:hidden] -- the button is not displayed in the toolbar
# self[:text] -- text for the button
# self[:onwhen] -- enable button if items are selected
#
# If disabled? is true, disable onwhen and set state and title unless
# user specifically enabled the button
def calculate_properties
self[:enabled] = !disabled? if self[:enabled].nil?
self[:title] = @error_message if @error_message.present?
enabled = !disabled?

# if :enabled is not set, use disabled?
self[:enabled] = enabled if self[:enabled].nil?

# if disabled? is true and user did not specify that :enabled is true
# then:
# set :onwhen to nil => do not enable when user select items
# set :title to error => show user the error message
unless self[:enabled] || enabled
self[:onwhen] = nil
self[:title] = @error_message if @error_message.present?
end
end

# Check if all instance variables for that button works with are set and
Expand Down