Change device_type from 'ethernet port' to 'physical_port' #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skovic@74abdcf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@skovic do you want to wait for the model to be changed first before we merge this? |
|
@juliancheal Yes, we would like for the model changes to go in first. Thanks |
|
ManageIQ/manageiq#15371 is merged ... Merging this to adjust the refresher so it sets the correct device type. |
|
Thanks @blomquisg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the device_type for ethernet ports to be 'physical_port' instead of 'ethernet port' due to pending changes in the model.