Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ref symlink for release build #265

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

simaishi
Copy link
Contributor

Create a release ref symlink (e.g. gaprindashvili-1) on fileshare, so we can easily find released builds later...

@simaishi simaishi changed the title Create symlink for release build Create ref symlink for release build Apr 25, 2018
# Also create relese ref symlink (e.g. gaprindashvili-1)
if cli_options[:type] == "release"
result = FileUtils.ln_s(directory_name, stream_directory.join(cli_options[:reference]), :verbose => true)
$log.info("Created release ref ink: #{result}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: s/ink/link/

@simaishi
Copy link
Contributor Author

Oops... fixed! Thanks 😄

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2018

Checked commit simaishi@40a51ed with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

scripts/vmbuild.rb

@carbonin carbonin self-assigned this Apr 26, 2018
@carbonin carbonin merged commit 173c49f into ManageIQ:master Apr 26, 2018
@carbonin carbonin added this to the Sprint 85 Ending May 7, 2018 milestone Apr 26, 2018
@simaishi simaishi deleted the create_ref_link branch April 26, 2018 14:04
simaishi pushed a commit that referenced this pull request Apr 26, 2018
Create ref symlink for release build
(cherry picked from commit 173c49f)
@simaishi
Copy link
Contributor Author

Gaprindashvili backport details:

$ git log -1
commit 89ce5dc94e76776cd94f7d4399e4d6be05288f4e
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Thu Apr 26 09:53:09 2018 -0400

    Merge pull request #265 from simaishi/create_ref_link
    
    Create ref symlink for release build
    (cherry picked from commit 173c49f16b09a41ca32f928f27b12194a40460e5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants