Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install 'mime-types' outside of bundle #254

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

simaishi
Copy link
Contributor

@simaishi simaishi commented Dec 4, 2017

It's needed to load rest-client in irb/automate. For bundle, we override with local path 'mime-types-redirector'

https://bugzilla.redhat.com/show_bug.cgi?id=1518865

@simaishi
Copy link
Contributor Author

simaishi commented Dec 4, 2017

cc @Fryguy @NickLaMuro

@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2017

Checked commit simaishi@631cb49 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit 13c4d92 into ManageIQ:master Dec 4, 2017
@Fryguy Fryguy added the blocker label Dec 4, 2017
@simaishi simaishi deleted the add_mime_types branch December 4, 2017 21:40
…client'

in irb/automate.  For bundle, we override with local path 'mime-types-redirector'

https://bugzilla.redhat.com/show_bug.cgi?id=1518865
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@simaishi
Copy link
Contributor Author

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit bb226ab0907912b62723dc4662992ba5dec0a0b5
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Dec 4 16:39:03 2017 -0500

    Merge pull request #254 from simaishi/add_mime_types
    
    Install 'mime-types' outside of bundle
    (cherry picked from commit 13c4d92aa883974ec8db92cefe79639cd0935938)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants