Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove container provider resume/pause #740

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Remove container provider resume/pause #740

merged 1 commit into from
Feb 14, 2020

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Feb 14, 2020 •
edited
Loading

Ability to pause/resume a container provider has been removed from the UI but it still accessible
via the API.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1750480

@miq-bot miq-bot added the wip label Feb 14, 2020
@miq-bot
Copy link
Member

miq-bot commented Feb 14, 2020

Checked commit d-m-u@a0dd650 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 14, 2020

Green on ops-ui and core.
@miq-bot add_label technical debt, bug

@agrare
Copy link
Member

agrare commented Feb 14, 2020 •
edited
Loading

Green on ops-ui and core.

@d-m-u do you have a cross-repo test pr or did you run the tests locally?

@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 14, 2020

@agrare I ran UI and core specs locally, do you need the cross-repo too?

@agrare
Copy link
Member

agrare commented Feb 14, 2020

@d-m-u yes just to be safe, thanks

@d-m-u d-m-u changed the title [WIP] Remove container provider resume/pause Remove container provider resume/pause Feb 14, 2020
@miq-bot miq-bot removed the wip label Feb 14, 2020
@d-m-u d-m-u mentioned this pull request Feb 14, 2020
Closed
@agrare agrare self-assigned this Feb 14, 2020
@agrare agrare merged commit 086814a into ManageIQ:master Feb 14, 2020
@agrare agrare added this to the Sprint 130 Ending Feb 17, 2020 milestone Feb 14, 2020
@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 14, 2020

thanks @agrare

@d-m-u d-m-u deleted the removing_provider_resume_pause branch February 14, 2020 19:01
@simaishi
Copy link
Contributor

@d-m-u can this be ivanchuk/yes?

@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 18, 2020

@miq-bot add_label ivanchuk/yes

simaishi pushed a commit that referenced this pull request Feb 21, 2020
@agrare @simaishi
Merge pull request #740 from d-m-u/removing_provider_resume_pause
e025d67 
Remove container provider resume/pause

(cherry picked from commit 086814a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805902
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit e025d675087172a27615522a9fad54ab4f621714
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Feb 14 14:00:11 2020 -0500

    Merge pull request #740 from d-m-u/removing_provider_resume_pause

    Remove container provider resume/pause

    (cherry picked from commit 086814a4a80cd1e83e2125338f96859d94394b20)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805902

d-m-u added a commit to d-m-u/manageiq that referenced this pull request Mar 3, 2020
@d-m-u
Remove defunct provider resume/pause
8534467 
Follow-up to ManageIQ/manageiq-api#740
@d-m-u d-m-u mentioned this pull request Mar 3, 2020
Merged
chessbyte added a commit to chessbyte/manageiq-documentation that referenced this pull request Apr 7, 2020
@chessbyte
Remove pause/resume documentation for Container Providers
171af88 
it was removed in ManageIQ/manageiq#19915 and ManageIQ/manageiq-api#740
@chessbyte chessbyte mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug ivanchuk/backported providers/containers technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @miq-bot @agrare @simaishi