Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the pxe_servers collection actions #678

Merged

Conversation

abellotti
Copy link
Member

Fixes the pxe_servers collection actions, PATCH and DELETE verbs should not
be exposed at the collection level, these are only resource verbs.

Added a test for the bulk delete action since this is now properly
exposed at the collection level.

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1754972

…ld not

be exposed at the collection level, these are only resource verbs.

Added a test for the bulk delete action since this is now properly
exposed at the collection level.

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1754972
@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2019

Checked commit abellotti@6e77469 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@gtanzillo gtanzillo added this to the Sprint 121 Ending Sep 30, 2019 milestone Sep 30, 2019
@gtanzillo gtanzillo merged commit 38e10c1 into ManageIQ:master Sep 30, 2019
simaishi pushed a commit that referenced this pull request Nov 1, 2019
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit 4c015eb47d5d107598ca352e537c90516a49bd42
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Sep 30 15:06:25 2019 -0400

    Merge pull request #678 from abellotti/fix_pxe_server_collection_actions
    
    Fixes the pxe_servers collection actions
    
    (cherry picked from commit 38e10c1c84d46338857b9a7131829e09889f4b0b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants