Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a subcollection under VMs for displaying CD-ROMs #605

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 5, 2019

This is required for the API-driven reconfigure VM screen where the user has to display the related CD-ROMs. Any change is going through the VmReconfigureRequest model that is already supported by the API, therefore, there's no need for anything else than GET.

GET /api/vms/2/cdroms
{
  "name": "cdroms",
  "count": 1127,
  "subcount": 1,
  "pages": 2,
  "resources": [
    {
      "href": "http://localhost:3000/api/vms/2/cdroms/4"
    }
  ],
  "links": {
    "self": "http://localhost:3000/api/vms/2/cdroms?offset=0",
    "next": "http://localhost:3000/api/vms/2/cdroms?offset=1000",
    "first": "http://localhost:3000/api/vms/2/cdroms?offset=0",
    "last": "http://localhost:3000/api/vms/2/cdroms?offset=1000"
  }
}


GET /api/vms/2/cdroms/4
{
  "href": "http://localhost:3000/api/vms/2/cdroms/4",
  "id": "4",
  "device_name": "CD/DVD drive 1",
  "device_type": "cdrom-image",
  "location": "1:0",
  "filename": "[]",
  "hardware_id": "5",
  "mode": null,
  "controller_type": "ide",
  "size": null,
  "free_space": null,
  "size_on_disk": null,
  "present": true,
  "start_connected": false,
  "auto_detect": null,
  "created_on": "2017-10-06T16:41:11Z",
  "updated_on": "2017-10-06T16:41:11Z",
  "disk_type": null,
  "storage_id": null,
  "backing_id": null,
  "backing_type": null,
  "storage_profile_id": null,
  "bootable": null
}

@miq-bot add_label hammer/no, changelog/yes
@miq-bot add_reviewer @abellotti
@miq-bot add_reviewer @lpichler

@skateman
Copy link
Member Author

skateman commented Jun 5, 2019

Same problem as with #598 and no idea how to fix it 😞

@lpichler
Copy link
Contributor

@skateman This branch has conflicts that must be resolved.

@skateman
Copy link
Member Author

@miq-bot rm_label unmergeable
@lpichler fixed

@miq-bot
Copy link
Member

miq-bot commented Jun 18, 2019

Checked commit skateman@89022b0 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@lpichler lpichler added this to the Sprint 114 Ending Jun 24, 2019 milestone Jun 18, 2019
@lpichler lpichler merged commit c9ad887 into ManageIQ:master Jun 18, 2019
@skateman skateman deleted the vm-cdroms-get branch June 18, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants