-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create Git backed automation domain #571
Add create Git backed automation domain #571
Conversation
@mkanoor Please review |
@Fryguy, @abellotti and @mkanoor Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Joe, a couple of questions/minor changes.
|
||
begin | ||
unless GitBasedDomainImportService.available? | ||
raise "Git owner role must enabled to import git repositories" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise BadRequestError, "Git owner ...."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abellotti Got it.
Some comments on commits jvlcek/manageiq-api@7dc2970~...7b07dd3 spec/requests/automate_domains_spec.rb
|
Checked commits jvlcek/manageiq-api@7dc2970~...7b07dd3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/api/automate_domains_controller.rb
|
Note: This PR relies on manageiq-ui-classic/5416 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Fixes #354 |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1600961
This PR, along with PR manageiq-ui-classic/5416 will provide the support to allow the API to be used to create a Git backed automation domain.
Steps for Testing/QA [Optional]
Create a GIT based automate domain repository.
Use the API to issue a POST command to `/api/automate_domains with data similar to:
{
"git_url": "https://gitlab.exampledomain.com/gitlab_repo/AwesomeDomain",
"ref_type": "branch",
"ref_name": "master",
}
e.g.: