TransformationMapping: API for adding mapping item

[mzazrivec]

This change implements new action (add_mapping_item) for transformation mapping: it adds new transformation mapping item to previously created transformation mapping.

Requested in https://trello.com/c/P5W747wT/217-spike-add-patch-method-to-api-transformationmappings-id (originally requested as a PATCH method, but using POST and new action is more straightforward).

Usage:

1. Create transformation mapping with empty list of transformation mapping items

$ cat create-mapping.json
{
    "name": "infra-mapping",
    "description": "infra-mapping",
    "state": "draft",
    "transformation_mapping_items": []
}
$ curl -X POST -d @create-mapping.json http://appliance-url/api/transformation_mappings
...

2. Add new transformation mapping item using the newly created action

$ cat add-mapping-item.json
{
    "action": "add_mapping_item",
    "resource": {
        "source": "/api/clusters/1",
        "destination": "/api/clusters/2"
    }
}
$ curl -X POST -d @add-mapping-item.json http://appliance-url/api/transformation_mappings/1

@himdel @michaelkro

https://bugzilla.redhat.com/show_bug.cgi?id=1689896

[djberg96]

👍

[djberg96]

@abellotti Can we merge?

[djberg96]

@miq-bot add_reviewer @abellotti

[djberg96]

A little syntactic sugar you can use here is the Object#tap method. So you can write that like this:

resource_search(id, type, collection_class(type)).tap do |mapping|
  mapping.transformation_mapping_items.append(create_mapping_items([data]))
  mapping.save!
end

[mzazrivec]

All right, fixed.

[miq-bot]

Checked commits mzazrivec/manageiq-api@aab74eb~...999d5ec with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[miq-bot]

@mzazrivec Cannot apply the following label because they are not recognized: transformation enhancement

[mzazrivec]

@miq-bot add_label transformation, enhancement

[djberg96]

@bdunne @abellotti Look ok?

[abellotti]

Thanks @mzazrivec for the API Enhancement. LGTM!!! 👍

[ghost]

https://bugzilla.redhat.com/show_bug.cgi?id=1689896

[ghost]

@miq-bot add_label hammer/yes

[simaishi]

Hammer backport details:

$ git log -1
commit 374b2be4874fc6bfdc92ecc9b111c9b4a4087064
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Mar 12 10:59:34 2019 -0400

    Merge pull request #546 from mzazrivec/transformation_mapping_add_mapping_item
    
    TransformationMapping: API for adding mapping item
    (cherry picked from commit 200ca55bb0736973dfaae9ad637da7d597d515f1)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693718