Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Use Vmdb::Appliance.PRODUCT_NAME instead of calling i18n #437

Merged
merged 1 commit into from
Jul 30, 2018
Merged

[RFE] Use Vmdb::Appliance.PRODUCT_NAME instead of calling i18n #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/api/api_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def server_info

def product_info
{
:name => I18n.t("product.name"),
:name => Vmdb::Appliance.PRODUCT_NAME,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK with relative to the ManageIQ/manageiq#17773 change

:name_full => I18n.t("product.name_full"),
:copyright => I18n.t("product.copyright"),
:support_website => I18n.t("product.support_website"),
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/entrypoint_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@

expect(response.parsed_body).to include(
"product_info" => a_hash_including(
"name" => I18n.t("product.name"),
"name" => Vmdb::Appliance.PRODUCT_NAME,
"name_full" => I18n.t("product.name_full"),
"copyright" => I18n.t("product.copyright"),
"support_website" => I18n.t("product.support_website"),
Expand Down