Fixed validation while adding user with multiple groups. #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
reviewed
Jul 23, 2018
| req_attrs << "password" if ::Settings.authentication.mode == "database" | ||
| bad_attrs = [] | ||
| req_attrs.each { |attr| bad_attrs << attr if data[attr].blank? } | ||
| bad_attrs << "group or miq_groups" if !data['group'] && !data['miq_groups'] |
There was a problem hiding this comment.
@abellotti @gtanzillo what do you think about this?
There was a problem hiding this comment.
@Hyperkid123 , @skateman - @abellotti and I looked at this and we are both ok with this change. We would just need some tests before merging.
gtanzillo
suggested changes
Jul 23, 2018
| req_attrs << "password" if ::Settings.authentication.mode == "database" | ||
| bad_attrs = [] | ||
| req_attrs.each { |attr| bad_attrs << attr if data[attr].blank? } | ||
| bad_attrs << "group or miq_groups" if !data['group'] && !data['miq_groups'] |
There was a problem hiding this comment.
@Hyperkid123 , @skateman - @abellotti and I looked at this and we are both ok with this change. We would just need some tests before merging.
|
@gtanzillo i will add them in the morning :) |
Hyperkid123
force-pushed
the
users-api-fix
branch
from
be9ca6e to
2071fbc
Compare
|
Checked commits Hyperkid123/manageiq-api@e479246~...2071fbc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a buggy validation while adding new user with multiple user groups. Attribute
namewas required even ifmiq_groupswas provided in data object.