Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUT to generic object definitions API #38

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Add PUT to generic object definitions API #38

merged 1 commit into from
Sep 7, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Aug 31, 2017

Add the ability to use PUT to edit a generic object definition (cc: @AparnaKarve)

Example usage

PUT /api/generic_object_definitions/:id
{
   "name" : "updated name",
   "description": "updated description"
}

@miq-bot add_label enhancement
@miq-bot assign @abellotti

@miq-bot
Copy link
Member

miq-bot commented Sep 7, 2017

Checked commit jntullo@2ebd1be with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@abellotti
Copy link
Member

This looks good to me @jntullo, thanks for the enhancement.

@AparnaKarve are you ok with this, can I go ahead and merge it ? Thanks.

@AparnaKarve
Copy link
Contributor

@abellotti Yes, this works great!

@jntullo Thank you!

@abellotti
Copy link
Member

LGTM!!

@abellotti abellotti merged commit 074a3b1 into ManageIQ:master Sep 7, 2017
@abellotti abellotti added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 7, 2017
imtayadeway added a commit to imtayadeway/manageiq-api that referenced this pull request Sep 7, 2017
This went red with the collision of ManageIQ#38 and ManageIQ#40 - updated to use the
new helper.
alexander-demicev pushed a commit to alexander-demicev/manageiq-api that referenced this pull request Oct 5, 2017
This went red with the collision of ManageIQ#38 and ManageIQ#40 - updated to use the
new helper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants