Folders subcollection on providers #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellotti
reviewed
Mar 6, 2018
config/api.yml
Outdated
| @@ -1122,6 +1122,13 @@ | |||
| :get: | |||
| - :name: read | |||
| :identifier: floating_ip_show | |||
| :folders: | |||
| :description: Datacenters | |||
| :identifier: datacenter_controller | |||
There was a problem hiding this comment.
should description be Folders ? Datacenter.all.collect(&:name) is a subset than EmsFolder.all.collect(&:name)
There was a problem hiding this comment.
@abellotti yup 😆 I started out doing datacenters...didn't change it to folders
jntullo
force-pushed
the
folders_subcollection
branch
2 times, most recently
from
7a535a7 to
bd41a99
Compare
abellotti
approved these changes
Mar 7, 2018
|
This pull request is not mergeable. Please rebase and repush. |
jntullo
force-pushed
the
folders_subcollection
branch
from
bd41a99 to
e4f287a
Compare
jntullo
force-pushed
the
folders_subcollection
branch
from
e4f287a to
97940d6
Compare
|
Checked commit jntullo@97940d6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of https://bugzilla.redhat.com/show_bug.cgi?id=1472279