Make cloud_tenants and flavors subcollections consistent with others #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror to be returned when they are requested. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545240
|
That should do it 👍 Thanks @jntullo |
|
Checked commit jntullo@6fc044e with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
abellotti
approved these changes
Feb 14, 2018
|
@abellotti Can this be |
|
yes, should be safe for gaprindashvili. Thanks. |
simaishi
pushed a commit
that referenced
this pull request
Sep 20, 2018
Make cloud_tenants and flavors subcollections consistent with others (cherry picked from commit b3a2bf8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1612905
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infra providers do not have
cloud_tenantsorflavors, causing a 500 error to be returned when they are requested. This makes the behavior consistent with other subcollections, checking to see if the object responds to the subcollection.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545240