Update role identifiers for tasks collection #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used in the UI When user roles are seeded, they have either the miq_task_all_ui feature or miq_task_my_ui feature (or both), which is what the UI also uses to validate that they can view requests. However, the API uses tasks_view. This is causing a problem where users that are able to see tasks in the UI are unable to see tasks through the API. This updates the product features used in the API to match what is used in the UI. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535962
|
Checked commit jntullo@d759db8 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This LGTM. Thanks @jntullo 👍 |
abellotti
approved these changes
Jan 23, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 6, 2018
Update role identifiers for tasks collection (cherry picked from commit 79e5081) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552278
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user roles are seeded, they have either the
miq_task_all_uifeature ormiq_task_my_uifeature (or both), which is what the UI also uses to validate that they can view requests. However, the API usestasks_view. This is causing a problem where users that are able to see tasks in the UI are unable to see tasks through the API. This updates the product features used in the API to match what is used in the UI.Note, no changes were needed for this due to
api_user_role_allows?method already accepting arrays, but have updated the api config spec accordingly, since this is the first place we are doing so.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535962