Remove Middleware API

[cfcosta]

Middleware Manager is being phased out, so is the API.

@miq-bot add_label gaprindashvili/yes

[miq-bot]

Checked commit cfcosta@cab292b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[abonas]

@miq-bot add_label providers/middleware

[abonas]

@cfcosta if this is an "as is" revert of the previous commit that added the api, it's better (and more clear) to send a regular revert

[cfcosta]

@abonas not exactly, it is a revert of the whole PR merge. It's the cleanest way of doing it, but it squashes all commits from the PR into one.

[abonas]

OK thanks

[abonas]

@abellotti @imtayadeway

[abonas]

test failures seem unrelated from a quick glance

[imtayadeway]

@cfcosta agreeing with @abonas - was this done by hand? If you do:

git revert -m 1 <sha of the merge commit>

It will add useful documentation for future git historians by linking to the original merge commit, and also providing details of any conflicts that needed to be fixed by hand.

[abellotti]

ping @cfcosta when you get a chance to push the git revert commit instead, Thanks!!

[cfcosta]

@imtayadeway @abellotti it was not done by hand, I did the git revert -m 1 but reworded the commit to provide more context. Either way, done!

[imtayadeway]

Thanks @cfcosta !

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 5d89abd08f0b1a90dd109b3a1d6601ede7db8f45
Author: Tim Wade <imtayadeway@users.noreply.github.com>
Date:   Tue Jan 2 13:03:57 2018 -0800

    Merge pull request #255 from cfcosta/remove-middleware-api
    
    Remove Middleware API
    (cherry picked from commit f4f2ca76db3584f5e5a665c708c2d8bff169479c)