Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for /api/orchestration_stacks #196

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Add support for /api/orchestration_stacks #196

merged 2 commits into from
Nov 22, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Nov 9, 2017

  • Add new collection
  • GETs and queries
  • supports custom_actions

As per earlier discussion, added in orchestration_stacks collection to work with custom actions. cc: @gmcculloug

@miq-bot add_label enhancement
@miq-bot assign @abellotti

@miq-bot
Copy link
Member

miq-bot commented Nov 17, 2017

This pull request is not mergeable. Please rebase and repush.

@jntullo jntullo changed the title [WIP] Add support for /api/orchestration_stacks Add support for /api/orchestration_stacks Nov 21, 2017
@miq-bot miq-bot removed the wip label Nov 21, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

This pull request is not mergeable. Please rebase and repush.

Jillian Tullo added 2 commits November 22, 2017 08:29
@miq-bot
Copy link
Member

miq-bot commented Nov 22, 2017

Checked commits jntullo/manageiq-api@7a0a8a6~...f4828e9 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍰

@abellotti
Copy link
Member

LGTM!!

The only thing needed is the followup PR to properly support subresource action identifiers and update the api.yml here and spec accordingly. Thanks.

@abellotti abellotti added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 22, 2017
@abellotti abellotti merged commit 9aeaebd into ManageIQ:master Nov 22, 2017
@AllenBW
Copy link
Member

AllenBW commented Aug 20, 2018

@abellotti @simaishi we might need this backported to G to solve https://bugzilla.redhat.com/show_bug.cgi?id=1614059

jrafanie pushed a commit to jrafanie/manageiq-api that referenced this pull request Aug 20, 2018
@simaishi
Copy link
Contributor

Backported to Gaprindashvili via #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants