Search for resources based on href_slug for automate workspace #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellotti
approved these changes
Oct 5, 2017
|
LGTM!! Thanks @mkanoor for the enhancement. will merge when all is 🍏 |
|
Checked commit mkanoor@5977697 with ruby 2.3.5, rubocop 0.47.1, and haml-lint 0.20.0 |
If this is the case, have we considered making the GUID the primary key for automate workspaces, so that we don't have to duplicate the knowledge of how to look up automate workspaces everywhere we need one? |
|
Could be revisited in the future, I'll leave that decision to @mkanoor. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate workspaces can only be accessed using GUID's and not ID's. The href_slug for Automate Workspaces includes the GUID. The search function has been modified to account for that.