-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Add subscribtion test blocker. #10272
Conversation
@@ -181,6 +182,8 @@ def test_rh_registration( | |||
Bugzilla: | |||
1532201 | |||
""" | |||
if GH(('ManageIQ/manageiq', 20390)).blocks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not include this in the meta blockers?
This needs to be skipped/blocked like this:
GH('ManageIQ/integration_tests:8128'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshriver If you mean to use GH('ManageIQ/manageiq:20390')
then I believe those approaches are equivalent.
Looking at the results I see the skip did work fine. The failed test_rh_updates
is not related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use blockers meta marker for GH or BZ skipping.
@JaryN we have the marker to to have consistency across the framework. |
@@ -181,6 +182,9 @@ def test_rh_registration( | |||
Bugzilla: | |||
1532201 | |||
""" | |||
bug = GH('ManageIQ/manageiq:20390') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the existing meta
marker and include the blockers
kwarg, as it supports GH issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshriver Thanks. I planned to make the skip conditional and forgot about that. However, with the current configuration it blocks all the tests anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the meta blockers
kwarg instead of skipping within the pytest run phase.
Adds blocker for ManageIQ/manageiq#20390
{{ py.test: -sv 'cfme/tests/configure/test_register_appliance.py::test_rh_registration' --long-running --use-provider 'complete' }}