Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Add subscribtion test blocker. #10272

Merged
merged 1 commit into from
Aug 19, 2020
Merged

[1LP][RFR] Add subscribtion test blocker. #10272

merged 1 commit into from
Aug 19, 2020

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Jul 27, 2020

Adds blocker for ManageIQ/manageiq#20390
{{ py.test: -sv 'cfme/tests/configure/test_register_appliance.py::test_rh_registration' --long-running --use-provider 'complete' }}

@jarovo jarovo changed the title Add subscribtion test blocker. [WIPTEST] Add subscribtion test blocker. Jul 27, 2020
@jarovo jarovo changed the title [WIPTEST] Add subscribtion test blocker. [RFR] Add subscribtion test blocker. Jul 28, 2020
@valaparthvi valaparthvi changed the title [RFR] Add subscribtion test blocker. [1LP][RFR] Add subscribtion test blocker. Jul 28, 2020
@@ -181,6 +182,8 @@ def test_rh_registration(
Bugzilla:
1532201
"""
if GH(('ManageIQ/manageiq', 20390)).blocks:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not include this in the meta blockers?

This needs to be skipped/blocked like this:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshriver If you mean to use GH('ManageIQ/manageiq:20390') then I believe those approaches are equivalent.

Looking at the results I see the skip did work fine. The failed test_rh_updates is not related to this PR.

@mshriver mshriver changed the title [1LP][RFR] Add subscribtion test blocker. [1LP][WIPTEST] Add subscribtion test blocker. Jul 31, 2020
Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use blockers meta marker for GH or BZ skipping.

@jarovo jarovo changed the title [1LP][WIPTEST] Add subscribtion test blocker. [1LP][RFR] Add subscribtion test blocker. Aug 12, 2020
@jawatts
Copy link
Contributor

jawatts commented Aug 13, 2020

@JaryN we have the marker to to have consistency across the framework.

@@ -181,6 +182,9 @@ def test_rh_registration(
Bugzilla:
1532201
"""
bug = GH('ManageIQ/manageiq:20390')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the existing meta marker and include the blockers kwarg, as it supports GH issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshriver Thanks. I planned to make the skip conditional and forgot about that. However, with the current configuration it blocks all the tests anyway.

Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the meta blockers kwarg instead of skipping within the pytest run phase.

@mshriver mshriver changed the title [1LP][RFR] Add subscribtion test blocker. [1LP][WIPTEST] Add subscribtion test blocker. Aug 17, 2020
@jarovo jarovo changed the title [1LP][WIPTEST] Add subscribtion test blocker. [1LP][RFR] Add subscribtion test blocker. Aug 18, 2020
@mshriver mshriver added the blockers-only To be applied on PRs which contain blocker modifications ONLY label Aug 19, 2020
@mshriver mshriver merged commit 858aa1b into ManageIQ:master Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blockers-only To be applied on PRs which contain blocker modifications ONLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants