This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Fix dialog dropdown weird behavior. #10265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the type of the dropdown values is not defined, the dialog behaves weirdly. For example it doesn't make the Submit button available if something is selected and complains something has to be selected. When nothing is touched when Ordering a catalog using this dialog is permitted. This quite the opposite to what makes sense. This is surely a problem of CFME backend -- it shouldn't allow us to not define a dropdown without a value type defined. But this cannot happen trough the UI so perhaps not worthy fixing.
mshriver
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type of the dropdown values is not defined, the dialog behaves
weirdly. For example it doesn't make the Submit button available if something is
selected. Also when nothing is touched when Ordering the catalog using this
dialog, Submit btn is enabled.. This quite the oposite how it should work.
This is surely a problem of CFME backend -- it shouldn't allow us to not define
a dropdown without a value type defined. But this cannot happen trough
the UI so perhaps not worthy fixing.
There is probably no test that is broken. I checked the catalog ordering by hand after the test prepared everything
cfme/tests/services/test_config_provider_servicecatalogs.py::test_order_tower_catalog_item[ansible_tower-3.5-template_survey_job-v1]Note that ManageIQ/manageiq#20382 affects the test above.