This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[RFR] fix cloud-init tests #10264
Merged
[RFR] fix cloud-init tests #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
reviewed
Aug 4, 2020
mshriver
reviewed
Aug 6, 2020
| 'custom_template': {'name': 'oVirt cloud-init'} | ||
| } | ||
|
|
||
| THERE_IS_A_WAY_TO_CHECK_STATIC_IP_VM = True | ||
| # TODO remove this condition |
mshriver
reviewed
Aug 6, 2020
mshriver
reviewed
Aug 6, 2020
mshriver
reviewed
Aug 19, 2020
| username='root', password=static_mode_payload['root_password'], | ||
| timeout=ssh.CONNECT_TIMEOUT) | ||
|
|
||
| # Cleanup this explicitly because we can get to problems with ordering the cleanups of |
There was a problem hiding this comment.
Thanks for including this explanation of the explicit closes!
mshriver
approved these changes
Aug 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Adding test for DHCP configuration.
{{py.test: -sv cfme/tests/cloud_infra_common/test_cloud_init_provisioning.py::test_provision_cloud_init_payload --long-running --use-provider complete }}