Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fix provider filters in test_power_control_rest module #10180

Merged
merged 1 commit into from
Jun 17, 2020
Merged

[1LP][RFR] Fix provider filters in test_power_control_rest module #10180

merged 1 commit into from
Jun 17, 2020

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Jun 9, 2020

Fixed provider parametrization in test_power_control_rest.py so that the following uncollections no longer happen:

test_stop_vm_rest[satellite-6.2-small_template-from_detail] - Config Manager providers do not support this feature.
test_start_vm_rest[satellite-6.2-small_template-from_detail] - Config Manager providers do not support this feature.
test_suspend_vm_rest[satellite-6.2-small_template-from_detail] - Config Manager providers do not support this feature.
test_stop_vm_rest[satellite-6.2-small_template-from_collection] - Config Manager providers do not support this feature.
test_start_vm_rest[satellite-6.2-small_template-from_collection] - Config Manager providers do not support this feature.
test_suspend_vm_rest[satellite-6.2-small_template-from_collection] - Config Manager providers do not support this feature.
test_stop_vm_rest[ansible_tower-3.4-small_template-from_detail] - Config Manager providers do not support this feature.
test_start_vm_rest[ansible_tower-3.4-small_template-from_detail] - Config Manager providers do not support this feature.
test_suspend_vm_rest[ansible_tower-3.4-small_template-from_detail] - Config Manager providers do not support this feature.
test_stop_vm_rest[ansible_tower-3.4-small_template-from_collection] - Config Manager providers do not support this feature.
test_start_vm_rest[ansible_tower-3.4-small_template-from_collection] - Config Manager providers do not support this feature.
test_suspend_vm_rest[ansible_tower-3.4-small_template-from_collection] - Config Manager providers do not support this feature.
test_stop_vm_rest[ansible_tower-3.5-small_template-from_detail] - Config Manager providers do not support this feature.
test_start_vm_rest[ansible_tower-3.5-small_template-from_detail] - Config Manager providers do not support this feature.
test_suspend_vm_rest[ansible_tower-3.5-small_template-from_detail] - Config Manager providers do not support this feature.
test_stop_vm_rest[ansible_tower-3.5-small_template-from_collection] - Config Manager providers do not support this feature.
test_start_vm_rest[ansible_tower-3.5-small_template-from_collection] - Config Manager providers do not support this feature.
test_suspend_vm_rest[ansible_tower-3.5-small_template-from_collection] - Config Manager providers do not support this feature.
test_reset_vm_rest[small_template-from_detail] - Parametrization of fixture ['provider'] for cfme.tests.cloud_infra_common.test_power_control_rest.test_reset_vm_rest yielded no values, marking for uncollection.
test_reset_vm_rest[small_template-from_collection] - Parametrization of fixture ['provider'] for cfme.tests.cloud_infra_common.test_power_control_rest.test_reset_vm_rest yielded no values, marking for uncollection.

The 'Config Manager' uncollections are resolved by using a provider filter to exclude ConfigManager providers, instead of using a separate uncollectif mark.

The last two uncollections were due to an incorrect passing of classes to ProviderFilter, which is now fixed as well.

{{ pytest: -vv cfme/tests/cloud_infra_common/test_power_control_rest.py }}

@tpapaioa tpapaioa changed the title [WIPTEST] Fix provider filters in test_power_control_rest module [RFR] Fix provider filters in test_power_control_rest module Jun 9, 2020
@john-dupuy john-dupuy added enhancement test-cleanup Test removal, collection changes, re-organization labels Jun 16, 2020
@john-dupuy john-dupuy changed the title [RFR] Fix provider filters in test_power_control_rest module [1LP][RFR] Fix provider filters in test_power_control_rest module Jun 16, 2020
@mshriver mshriver self-assigned this Jun 17, 2020
@mshriver mshriver merged commit 45c8f48 into ManageIQ:master Jun 17, 2020
@tpapaioa tpapaioa deleted the fix_test_power_control_rest branch June 17, 2020 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement test-cleanup Test removal, collection changes, re-organization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants