This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Test to create group #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I detected some fixture changes in commit a95929c3858498d483d33851a077e9626b3c3d17 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
dgaikwad
force-pushed
the
test_create_group_console_no
branch
from
a95929c to
d4ec643
Compare
valaparthvi
approved these changes
May 21, 2020
Comment on lines
2892
to
2897
| @request.addfinalizer | ||
| def _cleanup(): | ||
| if cg.exists: | ||
| cg.delete() | ||
| if group.exists: | ||
| group.delete() |
There was a problem hiding this comment.
I'd rather add these deletion statements right after the creation statements.
something like -
cg = ....
request.addfinalizer(cg.delete_if_exists)
group = ....
request.addfinalizer(group.delete_if_exists)
On a second thought, you can simply use cg.delete and group.delete since there are no other destructive operations performed on either of them.
There was a problem hiding this comment.
@valaparthvi @dgaikwad
The BaseEntity class actually has a delete_if_exists method that was written for just such a scenario, please use it here.
valaparthvi
changed the title
valaparthvi
added
the
test-automation
mshriver
suggested changes
May 21, 2020
mshriver
changed the title
dgaikwad
force-pushed
the
test_create_group_console_no
branch
from
d4ec643 to
56755ea
Compare
dgaikwad
changed the title
mshriver
approved these changes
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding_test test to create group if at least one category show_in_console value is No
Purpose or Intent
PRT Run
{{pytest: cfme/tests/configure/test_access_control.py -k "test_create_group_console_no" --long-running -v}}