Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fixing the vm is_display #10101

Merged
merged 1 commit into from
May 8, 2020

Conversation

mnadeem92
Copy link
Contributor

@mnadeem92 mnadeem92 commented May 7, 2020

Signed-off-by: mnadeem92 mnadeem@redhat.com

{{ pytest: cfme/tests/v2v/test_csv_import.py -k "test_csv_valid_vm" --use-provider rhv-ims --use-provider vsphere67-ims --provider-limit 2 -v }}

vm is_display is failing due to the below line in is_display code

len(self.browser.elements(".//div[contains(@Class,'spinner')]")) == 0)

So, this line make sure that the vm loading spinner gets over which means vm data gets loaded in vm table.
However, in current upstream build, the background card view has been replaced with list view (As shown in attached screenshots), Due to which Now the spinner is available in background as well if multiple plans is in progress.
Now the issue is with is_display code --> .//div[contains(@Class,'spinner')]")) , It consider the background spinner as well in consideration and return False for vm is_display.

So, to be more specific to VM page, the spinner logic is replaced with the below text which display during loading of VM data.

not self.browser.elements(".//h3[contains(text(),'Discovering VMs')]")

Signed-off-by: mnadeem92 <mnadeem@redhat.com>
@mnadeem92
Copy link
Contributor Author

Screenshot from 2020-05-07 14-24-43

@mnadeem92 mnadeem92 changed the title Fixing the vm is_display [WIPTEST] Fixing the vm is_display May 7, 2020
@mnadeem92 mnadeem92 changed the title [WIPTEST] Fixing the vm is_display [RFR] Fixing the vm is_display May 7, 2020
@dajoRH dajoRH removed the WIP-testing label May 7, 2020
@sshveta sshveta changed the title [RFR] Fixing the vm is_display [1LP][RFR] Fixing the vm is_display May 7, 2020
@sshveta
Copy link
Contributor

sshveta commented May 7, 2020

Thanks for this PR @mnadeem92 👍

@jawatts jawatts self-assigned this May 8, 2020
Copy link
Contributor

@jawatts jawatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great description @mnadeem92

@jawatts jawatts merged commit 2c392d8 into ManageIQ:master May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants