This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Update docker-py 1.10 to docker 4.2 #10082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
force-pushed
the
update-docker-py
branch
from
52c3780 to
ec975fa
Compare
mshriver
changed the title
digitronik
reviewed
Apr 30, 2020
There was a problem hiding this comment.
With first look LGTM. I will test locally.
Thanks for dropping docker-py @mshriver
john-dupuy
approved these changes
May 5, 2020
There was a problem hiding this comment.
I was able to verify that running miq selenium-container locally worked, so LGTM. Worth noting that I had to nuke my venv even after uninstalling docker-py and installing docker.
Seemed to be related to docker/docker-py#1370
john-dupuy
changed the title
digitronik
reviewed
May 6, 2020
| @@ -33,7 +33,7 @@ def vnc_ready(addr, port): | |||
| @click.option('--image', help='Chooses selenium container image', | |||
| default=docker_conf.get('selff', 'cfmeqe/sel_ff_chrome')) | |||
| @click.option('--vncviewer', help='Chooses VNC viewer command', | |||
| default=docker_conf.get('vncviewer', 'vinagre')) | |||
| default=docker_conf.get('vncviewer', 'vncviewer')) | |||
There was a problem hiding this comment.
Optional:
Mike one thought came in mind like better to make xdg-open as default. maybe vncviewer not installed on user system
but our most of user use vncviewer
| @@ -33,7 +33,7 @@ def vnc_ready(addr, port): | |||
| @click.option('--image', help='Chooses selenium container image', | |||
| default=docker_conf.get('selff', 'cfmeqe/sel_ff_chrome')) | |||
There was a problem hiding this comment.
can we start using quay.io/redhatqe/selenium-standalone?
The structure of the library changed significantly, thus dockerbot needed significant changes Change docker API in dockerbot for container start kwargs
mshriver
force-pushed
the
update-docker-py
branch
from
ec975fa to
2c31fdc
Compare
digitronik
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of the library changed significantly, thus dockerbot needed significant changes
We no longer need to process info from inspect, and the interface for creating an running containers has completely changed.
I moved some of the logging around, and changed the logic to accommodate the docker API changes.
NOTE:
I stopped short of updating the dockerfile for the pytest container. It needs to be rewritten to use quickstart, but that is out of scope of trying to update our docker dependency.
The DockerInstance changes can be verified by running
miq-selenium-container