This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Adding test coverage for bugzilla #10079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadeem92
force-pushed
the
add_test_coverage
branch
from
April 27, 2020 05:59
d711de8
to
20adab8
Compare
ganeshhubale
suggested changes
Apr 27, 2020
valaparthvi
suggested changes
Apr 27, 2020
mnadeem92
force-pushed
the
add_test_coverage
branch
from
April 30, 2020 12:17
20adab8
to
925d887
Compare
valaparthvi
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the changes Ganesh suggested, everything looks fine to me. Thanks for the changes.
ganeshhubale
suggested changes
Apr 30, 2020
cfme/tests/v2v/test_v2v_manual.py
Outdated
@@ -2,6 +2,7 @@ | |||
import pytest | |||
|
|||
from cfme import test_requirements | |||
from cfme.utils.blockers import BZ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this import.
ganeshhubale
changed the title
[RFR] Adding test coverage for bugzilla
[WIPTEST] Adding test coverage for bugzilla
Apr 30, 2020
Signed-off-by: mnadeem92 <mnadeem@redhat.com>
mnadeem92
force-pushed
the
add_test_coverage
branch
from
April 30, 2020 14:59
925d887
to
e05ee3f
Compare
mnadeem92
changed the title
[WIPTEST] Adding test coverage for bugzilla
[RFR] Adding test coverage for bugzilla
Apr 30, 2020
valaparthvi
changed the title
[RFR] Adding test coverage for bugzilla
[1LP][RFR] Adding test coverage for bugzilla
Apr 30, 2020
digitronik
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mnadeem92 mnadeem@redhat.com