Skip to content

Commit

Permalink
Add verbose-print messages and set recorded animation step.
Browse files Browse the repository at this point in the history
  • Loading branch information
Malcolmnixon committed Sep 11, 2024
1 parent fce576e commit 6f41130
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 1 deletion.
4 changes: 4 additions & 0 deletions VERSIONS.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
# 0.2.0
- Add verbose print messages
- Set animation step

# 0.1.0
- Initial Revision
13 changes: 12 additions & 1 deletion addons/godot_animation_recorder/animation/animation_recorder.gd
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,20 @@ func start_recording() -> bool:
_bone_rotation_tracks = {}
_face_tracks = {}

# Set the animation rate
match skeleton.modifier_callback_mode_process:
Skeleton3D.ModifierCallbackModeProcess.MODIFIER_CALLBACK_MODE_PROCESS_PHYSICS:
animation.step = 1 / Engine.physics_ticks_per_second

Skeleton3D.ModifierCallbackModeProcess.MODIFIER_CALLBACK_MODE_PROCESS_IDLE:
animation.step = 1 / Engine.get_frames_per_second()

# Populate the tracks
_populate_skeleton_tracks()
_populate_face_tracks()

# Start the recording
print_verbose("GodotXRAnimationRecorder: Starting recording")
skeleton.skeleton_updated.connect(_on_skeleton_updated)
_start = _now()
_recording = true
Expand All @@ -192,17 +201,19 @@ func start_recording() -> bool:

## Stop recording
func stop_recording() -> bool:
# Fail if not recording
# Skip if not recording
if not _recording:
return false

# Stop the recording
print_verbose("GodotXRAnimationRecorder: Stopping recording")
_recording = false
skeleton.skeleton_updated.disconnect(_on_skeleton_updated)

# Optimize if requested
if optimize:
if animation.has_method("optimize"):
print_verbose("GodotXRAnimationRecorder: Optimizing animation")
animation.optimize(0.01, 0.01, 3)
else:
push_warning("Animation.optimize not supported")
Expand Down
12 changes: 12 additions & 0 deletions addons/godot_animation_recorder/tracker/tracker_player.gd
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ func play() -> void:
XRServer.add_tracker(_right_hand_tracker)
_count += 1

# Print verbose diagnostics
print_verbose("GodotXRTrackerPlayer: Starting playback")
if _body_tracker: print_verbose(" Playing body ", body_tracker_name)
if _face_tracker: print_verbose(" Playing face ", face_tracker_name)
if _left_hand_tracker: print_verbose(" Playing left hand ", left_hand_tracker_name)
if _right_hand_tracker: print_verbose(" Playing right hand ", right_hand_tracker_name)

# Start playing
_start = _now()
_playing = true
Expand All @@ -128,7 +135,12 @@ func play() -> void:

## Stop playback
func stop() -> void:
# Skip if not playing
if not _playing:
return

# Clear playing
print_verbose("GodotXRTrackerPlayer: Stopping playback")
_playing = false

# Remove any trackers
Expand Down
13 changes: 13 additions & 0 deletions addons/godot_animation_recorder/tracker/tracker_recorder.gd
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ func start_recording() -> void:
if _left_hand_tracker: left_hand_recording = GodotXRHandTrackerRecording.new()
if _right_hand_tracker: right_hand_recording = GodotXRHandTrackerRecording.new()

# Print verbose diagnostics
print_verbose("GodotXRTrackerRecorder: Stopping recording...")
if _body_tracker: print_verbose(" Recording body ", body_tracker_name)
if _face_tracker: print_verbose(" Recording face ", face_tracker_name)
if _left_hand_tracker: print_verbose(" Recording left hand ", left_hand_tracker_name)
if _right_hand_tracker: print_verbose(" Recording right hand ", right_hand_tracker_name)

# Start recording
_start = _now()
_recording = true
Expand All @@ -97,6 +104,12 @@ func start_recording() -> void:

## Stop recording
func stop_recording() -> void:
# Skip if not recording
if not _recording:
return

# Stop recording
print_verbose("GodotXRTrackerRecorder: Stopping recording")
_recording = false


Expand Down

0 comments on commit 6f41130

Please sign in to comment.