Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use :z for heatmap data property? #49

Closed
ssfrr opened this issue Jan 11, 2018 · 3 comments
Closed

use :z for heatmap data property? #49

ssfrr opened this issue Jan 11, 2018 · 3 comments

Comments

@ssfrr
Copy link
Contributor

ssfrr commented Jan 11, 2018

I generally think of heatmap and surface as being closely-related, so I figured I could update the data of a heatmap with hm[:z] = newdata, but apparently it wants hm[:heatmap] = newdata. Do you think :z might be a better property name for that, to match surface?

@SimonDanisch
Copy link
Member

I just went with the names that make the most sense to me - :z is absurd to me :D But I can also see, how it makes more sense in a data oriented (plotting) world, were x,y,z just enumerates dimensions, and not THE 3 spatial dimensions.
I don't have any strong preferences for the name and will just go with what most people feel comfortable with in the final version :)

@mkborregaard
Copy link
Contributor

To me @ssfrr 's idea is completely intuitive as well :-)

@ssfrr
Copy link
Contributor Author

ssfrr commented Oct 22, 2018

AFAICT heatmap property is now :color, which seems good to me, as that's the property being mapped to.

@ssfrr ssfrr closed this as completed Oct 22, 2018
SimonDanisch added a commit that referenced this issue Jun 3, 2021
flip text rotation to match cairo's coordinate system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants