Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makie.jl/REQUIRE should include AbstractNumbers #26

Closed
CrashBurnRepeat opened this issue Nov 30, 2017 · 3 comments
Closed

Makie.jl/REQUIRE should include AbstractNumbers #26

CrashBurnRepeat opened this issue Nov 30, 2017 · 3 comments

Comments

@CrashBurnRepeat
Copy link

Just went to use Makie and got an error about an uninstalled package AbstractNumbers. The dependency should be included in the REQUIRE list.
@mschauer
Copy link
Contributor

Makie requires manual installation, see https://github.com/SimonDanisch/Makie.jl#installation . AbstractNumbers is not yet registered and "If unregistered packages contain a REQUIRE file at the top of their source tree, that file will be used to determine which registered packages the unregistered package depends on"

@SimonDanisch
Copy link
Member

I'm working on registering a working, tagged version to integrate it into the REQUIRE :)

@CrashBurnRepeat
Copy link
Author

Ok, I think I was mislead about it being registered already when Pkg.add("AbstractNumbers") worked without complaint. I was looking into some other errors (in other packages) at the time, so I may not have been the most patient. Should this be kept open until it's registered, or closed since the README covers this?

@Benoit9 Benoit9 mentioned this issue Feb 25, 2019
Closed
SimonDanisch pushed a commit that referenced this issue Jun 3, 2021
@c42f
Refactor to simplify multiline geometry shader
febeb9f 
Here I've simplified the geometry shader for multilines significatnly so
that it always renders only the single central segment. The end points
are now accommodated by duplicating them with the index buffer.

Fixes #26 and greatly mitigates #27.

Ascii art FTW!
SimonDanisch pushed a commit that referenced this issue Jun 3, 2021
@c42f
Refactor to simplify multiline geometry shader
e041a3d 
Here I've simplified the geometry shader for multilines significatnly so
that it always renders only the single central segment. The end points
are now accommodated by duplicating them with the index buffer.

Fixes #26 and greatly mitigates #27.

Ascii art FTW!
SimonDanisch added a commit that referenced this issue Jun 3, 2021
@SimonDanisch
Merge pull request #26 from JuliaPlots/sd/fix_buttons
ad1ecc8 
fix all keyboard buttons
@chriswaudby chriswaudby mentioned this issue Feb 12, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SimonDanisch @mschauer @CrashBurnRepeat @asinghvi17