create a number input hook and refactor #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gudnuf
commented
Jan 28, 2025
gudnuf
commented
Jan 28, 2025
jbojcic1
reviewed
Jan 30, 2025
| USD: 'usd', | ||
| }; | ||
|
|
||
| export const getUnit = (currency: Currency) => { |
There was a problem hiding this comment.
should we maybe add this to to currency data map in money.ts and then expose it from there?
jbojcic1
reviewed
Jan 30, 2025
jbojcic1
reviewed
Jan 30, 2025
jbojcic1
reviewed
Jan 30, 2025
gudnuf
commented
Jan 31, 2025
gudnuf
commented
Jan 31, 2025
jbojcic1
reviewed
Jan 31, 2025
* create getLocaleDecimalSeperator function * use format to parts
* change return type and add loading state to useExchangeRate * rate is defined when not loading and no error * add all tickers back to query * useNumberInput - change initialization arguments (#296) * change initialization arguments * Money input cleanup (#297) --------- Co-authored-by: Josip Bojčić <jbojcic1@gmail.com> --------- Co-authored-by: Josip Bojčić <jbojcic1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a hook mostly because I want to be able to use the exchange rate hook directly. This could be done pretty much exactly the same if we used a store instead, we just would have to pass the exchange rate into the store when needed.
I also simplified the money toggle so now the input state tracks
valueandconvertedValue.Finally, I created a getUnit function to get the default units.