makes default and secondary variants for MoneyDisplay #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gudnuf
force-pushed
the
money-display-variants
branch
from
f2c724e to
21e416b
Compare
jbojcic1
approved these changes
Jan 23, 2025
gudnuf
added a commit
that referenced
this pull request
Jan 28, 2025
* color changes and move upgrade guest form * move upgrade-guest-form to settings dir * variants for the money-display (#286) * update guest form copy * deleted advanced settings and more style tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got rid of the size option and made the sizes based on the variant.
Right now we always have a big amount on top and then the converted amount below that is smaller and different colors.
Another option would be to have color variants separate from sizes, but that seems unnecessary right now.