make getProofsToSend more robust to refreshes
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gudnuf
commented
Oct 30, 2024
| @@ -540,28 +554,35 @@ export const useCashu = () => { | |||
| dispatch(setSending('Sending...')); | |||
|
|
|||
| try { | |||
| const proofsToSend = await getProofsToSend( | |||
| const proofsToSend = getProofsByAmount( | |||
There was a problem hiding this comment.
this was causing an unnecessary swap. Instead, we can just get the change from the wallet.meltTokens response.
jbojcic1
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a potential loss of funds from the time that
createSendableTokenwas called to when the calling function completed sending if, for example, the user refreshed the page while the sendable proofs were only in memory.I attempted to resolve this by storing the freshly created proofs back in localstorage, then removing them once they are either spent or saved elsewhere (ie. transaction history or database)