Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/3913/release changelog bug #3925

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Feb 11, 2025

Release changelog wrong has format

Closes: #3913

Description

The version-manager added the new line "[unreleased] (Added πŸš€ | Changed | Removed | Fixed 🐞 | Chore πŸ‘¨β€πŸ’» πŸ‘©β€πŸ’»)" correctly, but did not remove the "(Added πŸš€ | Changed | Removed | Fixed 🐞 | Chore πŸ‘¨β€πŸ’» πŸ‘©β€πŸ’»)" after the version, which lead to red tests in the release pipeline.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@BenediktMehl BenediktMehl force-pushed the tech/3913/release-changelog-bug branch from 75cea0d to 7d2e9a5 Compare February 11, 2025 14:20
Copy link

Copy link

@christian-huehn-mw christian-huehn-mw merged commit 21c66fa into main Feb 13, 2025
8 checks passed
@christian-huehn-mw christian-huehn-mw deleted the tech/3913/release-changelog-bug branch February 13, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releasing ana removes line from changelog
2 participants