Fixed a bug with swatches shown even for out-of-stock variants

[empiricompany]

Description (*)

In the product list, all swatches are always shown even if they are not available.
You can verify this on the PDP because only the available ones are displayed correctly.

Tested with both enabled and disabled stock inventory configuration "Display Out of Stock Products"

When "Display Out of Stock Products" is enabled shown correctly like this:

When "Display Out of Stock Products" is disabled all swatches are always shown even if they are not available.
With this patch shown correctly like this:

The bug occurs when the " Display Out of Stock Products" configuration is disabled.

Related Pull Requests

OpenMage/magento-lts#4100

Fixed Issues (if relevant)

OpenMage/magento-lts#3527

Manual testing scenarios (*)

1. Create configurable product with options as swatch such as color
2. Set stock unavailable for one color option

Example with sample data:

1. In product configurable Name: "Nolita cami" SKU "wbk000c" set all children products with color pink unavailable.

In the product list, all colors are always shown even if they are not available.
You can verify this on the PDP because only the available ones are displayed correctly.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

the first PR ❤️!

[fballiano]

I was wondering of this would impact websites that do not use stock levels, but as far as I can see this filter is used in many places in the core, without checking if the stock is enabled or not

so I think it should be safe to merge

[fballiano]

will make a couple of test and merge ASAP

[fballiano]

• tested on products with stock enabled
• tested on products where only some simple have stock enabled and some don't

all situations work, so for me it's a yes