Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of modal flyouts. #824

Closed
wants to merge 11 commits into from
Closed

Initial implementation of modal flyouts. #824

wants to merge 11 commits into from

Conversation

grokys
Copy link
Contributor

@grokys grokys commented Nov 26, 2013

Trying again... I hate Git sometimes!

@AzureKitsune
Copy link
Member

Hmmm, I don't my VS with me at the moment. How is that Modal grid any different from the overlay used by Dialogs? Also, you have to add it to the CleanWindow style as well.

@grokys
Copy link
Contributor Author

grokys commented Nov 26, 2013

The dialog overlay is on top of FlyoutsControl so it disables the Flyouts as well as the main window content . I assume this is desirable behaviour.

If you think I'm on the right track I can add it to CleanWindow too.

@AzureKitsune
Copy link
Member

Yes, you are on the right track. CleanWindow needs to have this before the PR can be merged.

@grokys
Copy link
Contributor Author

grokys commented Nov 29, 2013

Just took a look at adding this to the CleanWindow style but it appears that Flyouts don't currently work with CleanWindow; if I apply the CleanWindowStyle to the FlyoutDemo nothing happens when I click a button...

@flagbug
Copy link
Member

flagbug commented Nov 29, 2013

Nice! Just one thing, can you use the Grid here for creating the overlay effect, or if thats not possible, respect the current Theme for the overlay color?

@grokys
Copy link
Contributor Author

grokys commented Nov 29, 2013

Hi @flagbug, as discussed about the currently existing overlay can't be used as it's on top of FlyoutsControl. I can make it respect the theme; what color should I use? BlackColorBrush as for the existing modal overlay?

@flagbug
Copy link
Member

flagbug commented Nov 29, 2013

@grokys Yup

@AzureKitsune
Copy link
Member

@grokys Once you replicate your changes in MetroWindow.xaml into CleanWindow.xaml, we can merge this. 😄

@grokys
Copy link
Contributor Author

grokys commented Dec 2, 2013

#835 is holding me up on this.

@AzureKitsune
Copy link
Member

@grokys Done. See #840

@grokys
Copy link
Contributor Author

grokys commented Dec 3, 2013

This should now be implemented.

@AzureKitsune
Copy link
Member

Oh man, the merge broke something. We won't be able to merge this "nicely". I'll see about manually merging this tonight.

@grokys
Copy link
Contributor Author

grokys commented Dec 3, 2013

Hmm, this seems to happen every time I fork a repo. Wonder what I'm doing wrong?

@AzureKitsune
Copy link
Member

Usually, it is better to rebase instead of merge.

@grokys
Copy link
Contributor Author

grokys commented Dec 3, 2013

Yeah, that's what I did...

@flagbug
Copy link
Member

flagbug commented Dec 6, 2013

Merged by hand, thanks @grokys !

@flagbug flagbug closed this Dec 6, 2013
@grokys
Copy link
Contributor Author

grokys commented Dec 6, 2013

Thanks a million @flagbug - was about to do that myself this evening!

@grokys grokys deleted the modal-flyout branch December 6, 2013 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants