-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of modal flyouts. #824
Conversation
Hmmm, I don't my VS with me at the moment. How is that Modal grid any different from the overlay used by Dialogs? Also, you have to add it to the CleanWindow style as well. |
The dialog overlay is on top of FlyoutsControl so it disables the Flyouts as well as the main window content . I assume this is desirable behaviour. If you think I'm on the right track I can add it to CleanWindow too. |
Yes, you are on the right track. CleanWindow needs to have this before the PR can be merged. |
Just took a look at adding this to the CleanWindow style but it appears that Flyouts don't currently work with CleanWindow; if I apply the CleanWindowStyle to the FlyoutDemo nothing happens when I click a button... |
Nice! Just one thing, can you use the Grid here for creating the overlay effect, or if thats not possible, respect the current Theme for the overlay color? |
Hi @flagbug, as discussed about the currently existing overlay can't be used as it's on top of FlyoutsControl. I can make it respect the theme; what color should I use? BlackColorBrush as for the existing modal overlay? |
@grokys Yup |
@grokys Once you replicate your changes in MetroWindow.xaml into CleanWindow.xaml, we can merge this. 😄 |
#835 is holding me up on this. |
This should now be implemented. |
Oh man, the merge broke something. We won't be able to merge this "nicely". I'll see about manually merging this tonight. |
Hmm, this seems to happen every time I fork a repo. Wonder what I'm doing wrong? |
Usually, it is better to rebase instead of merge. |
Yeah, that's what I did... |
Merged by hand, thanks @grokys ! |
Thanks a million @flagbug - was about to do that myself this evening! |
Trying again... I hate Git sometimes!