Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Binding before executing the command of "TextBoxHelper.ButtonCommand" #3925

Merged
merged 3 commits into from Oct 5, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 28, 2020

Describe the changes you have made to improve this project

Now an update of the binding is done before executing the command of "TextBoxHelper.ButtonCommand".

Unit test

guess not

Additional context

See #3924

Closed Issues

#3924

@dnfadmin
Copy link

dnfadmin commented Sep 28, 2020

CLA assistant check
All CLA requirements met.

Rerago added 2 commits September 29, 2020 08:39
The update is not necessary in this context
All others have the DefaultUpdateSourceTrigger not on LostFocus and therefore no problem.
@punker76 punker76 added this to the 2.2.1 milestone Oct 5, 2020
@punker76 punker76 linked an issue Oct 5, 2020 that may be closed by this pull request
@punker76 punker76 merged commit 0936dac into MahApps:develop Oct 5, 2020
@punker76
Copy link
Member

punker76 commented Oct 5, 2020

@Rerago your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Binding updates for buttons from TextBoxHelper.ButtonCommand
2 participants